Add CI test for fallback allgather, allreduce, broadcastand reducescatter to NCCL operations#485
Merged
Binyang2014 merged 7 commits intomainfrom Mar 27, 2025
Merged
Conversation
…tter to NCCL operations
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
… that CUDA is installed in the /usr/local/cuda
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Binyang2014
reviewed
Mar 21, 2025
Contributor
Binyang2014
left a comment
Binyang2014
left a comment
There was a problem hiding this comment.
Let's make it simple, just run test with/without fallback nccl. For example for allgather, just run test with MSCCLPP_FORCE_NCCL_FALLBACK_OPERATION="allgather" and MSCCLPP_FORCE_NCCL_FALLBACK_OPERATION="other_collective". Other cases we can cover it via unit-test
Contributor
|
Another thing, can we add document for these env variables? |
Contributor
|
/azp run |
Binyang2014
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI test for fallback allgather, allreduce, broadcast, and reducescatter to NCCL operations
Test following parameters:
-x MSCCLPP_ENABLE_NCCL_FALLBACK=TRUE
-x MSCCLPP_NCCL_LIB_PATH=/path_to_nccl/nccl/build/lib/libnccl.so
-x MSCCLPP_FORCE_NCCL_FALLBACK_OPERATION="allgather, allreduce, broadcast, reducescatter" or "all"