Revise NCCL API implementation#617

Merged

Binyang2014 merged 52 commits intomainfrom

binyli/nccl-algo

Sep 26, 2025

Contributor

Binyang2014 commented Aug 19, 2025 •

edited

Loading

Make nccl interface extensible. Customer can register their own algo to NCCL API. User can provide customized algo selection function.
Fallback to NCCL/RCCL if no algo is selected based on algo selection function
MSCCLPP interfaces now works for any scale

Binyang2014 added 27 commits

August 18, 2025 03:18

WIP

a91d273

WIP

2fb4d74

WIP

cc96414

WIP

d561a5c

WIP

0dfc13a

WIP

11b3bdb

WIP

a9e98ec

WIP

f89ffe4

WIP

82211f6

WIP

978a182

WIP

b89697d


          Fix correctness

0f7ce20

WIP

e620110


          clean code

9df8ca3


          all works

c922620

WIP

b5a8793


          Merge branch 'main' into binyli/nccl-algo

f1a905f


          clean up

1235a90

WIP

030a4c2


          bug fix

7bcd613


          fix compile error

f1cde8b

WIP

775f48e


          for amd

ca638b5

WIP

646656b

WIP

25f4ee2

WIP

52211ce


          add logs

ffae384

Binyang2014 marked this pull request as ready for review

August 24, 2025 18:40

Contributor Author

Binyang2014 commented Aug 24, 2025

/azp run

azure-pipelines bot commented Aug 24, 2025

Azure Pipelines successfully started running 3 pipeline(s).

Binyang2014 added 11 commits

August 29, 2025 22:29

WIp

d1e636a

WIP

33c6eb5


          update doc

44196ec


          update

0cbe6d7


          refactor

04e53c8


          merge main

4f91a50

WIP

WIP

351b5b0


          Merge branch 'main' into binyli/nccl-algo

bc468b9


          update

fde6120


          Merge branch 'main' into binyli/nccl-algo

fb7405b

caiomcbr reviewed

View reviewed changes

include/mscclpp/algorithm.hpp Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

include/mscclpp/algorithm.hpp Outdated Show resolved Hide resolved

Binyang2014 added 2 commits

September 25, 2025 20:29


          merge main

11b1364


          Address comments

242ab3a

caiomcbr reviewed

View reviewed changes

docs/guide/customized-algorithem-with-nccl-api.md Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

caiomcbr reviewed

View reviewed changes

apps/nccl/src/nccl.cu Outdated Show resolved Hide resolved

WIP

ae8a9d0

caiomcbr approved these changes

View reviewed changes

Contributor

caiomcbr left a comment

LGTM

Contributor Author

Binyang2014 commented Sep 25, 2025

/azp run

azure-pipelines bot commented Sep 25, 2025

Azure Pipelines successfully started running 3 pipeline(s).

Binyang2014 merged commit 70b8297 into main

29 checks passed

Binyang2014 deleted the binyli/nccl-algo branch

September 26, 2025 17:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet