Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the pidfd mechanism for file descriptor sharing with a Unix socket-based approach. The change eliminates dependencies on Linux-specific system calls (SYS_pidfd_open and SYS_pidfd_getfd) in favor of a more portable Unix domain socket implementation.
- Introduces UnixSocketServer and UnixSocketClient classes for file descriptor transmission
- Updates RegisteredMemory and NvlsConnection to use Unix sockets instead of pidfd
- Integrates Unix socket server lifecycle with TcpBootstrap initialization
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/unix_socket.cc |
Implements Unix socket server/client for file descriptor transfer |
src/include/unix_socket.hpp |
Defines UnixSocketServer and UnixSocketClient class interfaces |
src/registered_memory.cc |
Replaces pidfd usage with Unix socket client calls |
src/nvls.cc |
Updates NVLS connection to use Unix socket for file descriptor sharing |
src/include/registered_memory.hpp |
Changes TransportInfo structure from pid/fd to fdId/localRankId |
src/bootstrap/bootstrap.cc |
Integrates Unix socket server startup and shutdown with bootstrap |
include/mscclpp/env.hpp |
Adds localRank field to Env class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use unix socket to share fd to other processes. Used for nvls handle sharing