Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses teardown issues by modifying error handling during cleanup operations. The changes improve robustness by ignoring certain CUDA/CU errors that may occur when pointers become invalid during teardown.
- Adds new CUDA error types to the teardown error detection functions
- Introduces a new macro to completely ignore CUDA driver API errors during cleanup
- Updates memory test to properly manage process group lifecycle
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/torch/memory_report.py | Improves process group management by using distinct variable names and explicitly destroying groups |
| src/gpu_utils.cc | Enhances error handling during teardown by expanding recognized teardown errors and adding ignore-only macro |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore cuda/cu errors during teardown. Some pointer may be invalid at this point