Skip to content

Add MSCCLPP_GIT_COMMIT micro#640

Merged
Binyang2014 merged 8 commits intomainfrom
binyli/version
Oct 6, 2025
Merged

Add MSCCLPP_GIT_COMMIT micro#640
Binyang2014 merged 8 commits intomainfrom
binyli/version

Conversation

@Binyang2014
Copy link
Contributor

  • Add MSCCLPP_GIT_COMMIT micro
  • Update docs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors version management by extracting version definitions from core.hpp into a dedicated template file and adds Git commit tracking capability.

  • Moves version constants from hardcoded values in core.hpp to a configurable version.hpp.in template
  • Adds MSCCLPP_GIT_COMMIT macro to track Git commit hashes
  • Updates build system to generate version.hpp from template and include Git hash detection

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
include/mscclpp/version.hpp.in New template file defining version macros and Git commit hash
include/mscclpp/core.hpp Removes hardcoded version definitions and includes generated version.hpp
include/CMakeLists.txt Updates to include generated headers in build configuration
docs/programming_guide.rst Adds new documentation reference
CMakeLists.txt Adds Git hash detection and version.hpp generation logic
.github/workflows/update-version.yml Removes redundant version update steps now handled by template

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@seagater seagater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. There are no other files rely on version and no new dependency besides of Git.

@Binyang2014 Binyang2014 merged commit 3d94383 into main Oct 6, 2025
14 checks passed
@Binyang2014 Binyang2014 deleted the binyli/version branch October 6, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants