Merged
Conversation
Contributor
Binyang2014
commented
Sep 29, 2025
- Add MSCCLPP_GIT_COMMIT micro
- Update docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors version management by extracting version definitions from core.hpp into a dedicated template file and adds Git commit tracking capability.
- Moves version constants from hardcoded values in core.hpp to a configurable version.hpp.in template
- Adds MSCCLPP_GIT_COMMIT macro to track Git commit hashes
- Updates build system to generate version.hpp from template and include Git hash detection
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| include/mscclpp/version.hpp.in | New template file defining version macros and Git commit hash |
| include/mscclpp/core.hpp | Removes hardcoded version definitions and includes generated version.hpp |
| include/CMakeLists.txt | Updates to include generated headers in build configuration |
| docs/programming_guide.rst | Adds new documentation reference |
| CMakeLists.txt | Adds Git hash detection and version.hpp generation logic |
| .github/workflows/update-version.yml | Removes redundant version update steps now handled by template |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a850b6d to
1d65a5c
Compare
seagater
reviewed
Oct 3, 2025
seagater
approved these changes
Oct 6, 2025
Contributor
seagater
left a comment
There was a problem hiding this comment.
The PR looks good. There are no other files rely on version and no new dependency besides of Git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.