Address corner case when generating version file#641
Merged
Binyang2014 merged 19 commits intomainfrom Oct 7, 2025
Merged
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Binyang2014
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a corner case in version file generation by ensuring the MSCCLPP_HOME environment variable is set early in the initialization process and improving version string handling.
- Moved MSCCLPP_HOME environment variable setup earlier in the initialization process
- Improved version string pattern matching to handle different version formats
- Updated comments to use generic version format examples
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/mscclpp/init.py | Moved MSCCLPP_HOME environment variable setup to the top of the file before version retrieval |
| _build_version_metadata.py | Improved regex pattern for version string manipulation and updated comments with generic examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
seagater
reviewed
Oct 6, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
seagater
approved these changes
Oct 7, 2025
Contributor
seagater
left a comment
seagater
left a comment
There was a problem hiding this comment.
The changes looks good to me. Since we use default version format "mscclpp-0.8.0.post1.dev0+gc632fee37.d20251007". It's ok to remove the special _build_version_metadata.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address corner case for version file generation