Address installation issue in some env#750
Merged
Binyang2014 merged 2 commits intomainfrom Feb 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the nlohmann/json library dependency management to address installation issues in certain environments. The changes upgrade the library from version 3.11.2/3.11.3 to 3.12.0 and switch from URL-based tarball fetching to Git repository-based fetching.
Changes:
- Upgraded nlohmann/json from v3.11.2/v3.11.3 to v3.12.0 across all CMake configuration files
- Changed FetchContent method from URL-based tarball download to Git repository cloning
- Standardized the dependency declaration format to be consistent across main and test configurations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CMakeLists.txt | Updated nlohmann/json from v3.11.3 URL tarball to v3.12.0 Git repository, using multi-line FetchContent_Declare format |
| test/mscclpp-test/CMakeLists.txt | Updated nlohmann/json from v3.11.2 URL tarball to v3.12.0 Git repository, using multi-line FetchContent_Declare format |
chhwang
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way the
nlohmann/jsonlibrary is fetched and upgrades it to a newer version in both the main build and test configuration files.Addressed installation issue in some env