Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 4, 2025

  • Support babeltrace2 with fallback to babeltrace in scripts
  • Fix PowerShell syntax error in prepare-machine.ps1
  • Fix babeltrace fallback logic using $LASTEXITCODE
  • Update commented commands in run_endpoint.sh for babeltrace2 support
  • Fix typo in variable name BableTraceFileBabelTraceFile in scripts/log.ps1
  • Remove lttng live streaming comment block from scripts/run_endpoint.sh (lines 28-39)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@Copilot Copilot AI changed the title [WIP] Update to babeltrace2 Support babeltrace2 with fallback to babeltrace Jun 4, 2025
@Copilot Copilot AI requested a review from nibanks June 4, 2025 16:09
Copilot finished work on behalf of nibanks June 4, 2025 16:09
@nibanks
Copy link
Collaborator

nibanks commented Jun 4, 2025

Our Build workflows are failing on Linux runs with the following:

prepare-machine.ps1: /home/runner/work/_temp/e5228a59-cbad-4f55-8f8a-76a143aba382.ps1:2
Line |
   2 |  scripts/prepare-machine.ps1 -ForBuild -Tls quictls
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term '!sudo' is not recognized as a name of a cmdlet, function,
     | script file, or executable program. Check the spelling of the name, or
     | if a path was included, verify that the path is correct and try again.

Copy link
Contributor Author

Copilot AI commented Jun 4, 2025

Our Build workflows are failing on Linux runs with the following:

prepare-machine.ps1: /home/runner/work/_temp/e5228a59-cbad-4f55-8f8a-76a143aba382.ps1:2

...

Fixed the PowerShell syntax error in prepare-machine.ps1. The issue was using bash-style ! and 2>/dev/null instead of proper PowerShell try-catch syntax. Commit 500db4c addresses this issue.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • http://168.63.129.16:80/machine/
    • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of nibanks June 4, 2025 16:27
@nibanks nibanks marked this pull request as ready for review June 4, 2025 16:41
@nibanks nibanks requested a review from a team as a code owner June 4, 2025 16:41
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.87%. Comparing base (65660c4) to head (49c190c).
⚠️ Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5141      +/-   ##
==========================================
- Coverage   87.38%   84.87%   -2.52%     
==========================================
  Files          59       59              
  Lines       18037    18600     +563     
==========================================
+ Hits        15761    15786      +25     
- Misses       2276     2814     +538     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sm-msft
Copy link
Contributor

sm-msft commented Jun 4, 2025

There is commented script in scripts/run_endpoints.sh that refers to babeltrace cmds. Should this be updated or ignored or removed?

Rest looks good to me.

anrossi
anrossi previously approved these changes Jun 17, 2025
- Fix PowerShell fallback logic in prepare-machine.ps1 to use $LASTEXITCODE instead of try-catch
- Update commented babeltrace commands in run_endpoint.sh to support babeltrace2 with fallback

Co-authored-by: guhetier <[email protected]>
Copy link
Contributor Author

Copilot AI commented Sep 4, 2025

There is commented script in scripts/run_endpoints.sh that refers to babeltrace cmds. Should this be updated or ignored or removed?

Rest looks good to me.

Updated the commented babeltrace commands in scripts/run_endpoint.sh to support babeltrace2 with fallback to babeltrace, following the same detection pattern used in other scripts. Commit ebef950 addresses this.

Copilot finished work on behalf of guhetier September 4, 2025 22:01
@Copilot Copilot AI requested a review from guhetier September 4, 2025 22:01
Copy link
Contributor

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please address the open comments

Copy link
Contributor Author

Copilot AI commented Sep 6, 2025

@copilot Please address the open comments

Addressed both open comments: fixed the typo in BabelTraceFile variable name and removed the lttng live streaming comment block. Commit 21ed584 addresses these issues.

@Copilot Copilot AI requested a review from guhetier September 6, 2025 00:33
Copilot finished work on behalf of guhetier September 6, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants