-
Notifications
You must be signed in to change notification settings - Fork 601
Support babeltrace2 with fallback to babeltrace #5141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: nibanks <[email protected]>
Our Build workflows are failing on Linux runs with the following:
|
…lation Co-authored-by: nibanks <[email protected]>
... Fixed the PowerShell syntax error in prepare-machine.ps1. The issue was using bash-style Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5141 +/- ##
==========================================
- Coverage 87.38% 84.87% -2.52%
==========================================
Files 59 59
Lines 18037 18600 +563
==========================================
+ Hits 15761 15786 +25
- Misses 2276 2814 +538 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There is commented script in scripts/run_endpoints.sh that refers to babeltrace cmds. Should this be updated or ignored or removed? Rest looks good to me. |
- Fix PowerShell fallback logic in prepare-machine.ps1 to use $LASTEXITCODE instead of try-catch - Update commented babeltrace commands in run_endpoint.sh to support babeltrace2 with fallback Co-authored-by: guhetier <[email protected]>
Updated the commented babeltrace commands in scripts/run_endpoint.sh to support babeltrace2 with fallback to babeltrace, following the same detection pattern used in other scripts. Commit ebef950 addresses this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please address the open comments
…omment Co-authored-by: guhetier <[email protected]>
BableTraceFile
→BabelTraceFile
in scripts/log.ps1✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.