Fix memory leak in ServerSendIp error paths by adding missing CXPLAT_FREE calls #5324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ServerSendIp
function inquicipserver.cpp
was leaking memory in two error paths where allocated buffers were not being freed before returning.Issue:
The function allocates memory using
CXPLAT_ALLOC_PAGED
but failed to free it when eitherStreamOpen
orStreamStart
operations failed:Solution:
Added
CXPLAT_FREE(SendBufferRaw, QUIC_POOL_TOOL);
calls before returning in both error paths to ensure proper memory cleanup. This matches the pattern already used in other error paths within the same function and ensures every allocation has a corresponding deallocation.The fix is minimal and surgical - only two lines added to prevent memory leaks without affecting any existing functionality.
Fixes #5255.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.