-
Notifications
You must be signed in to change notification settings - Fork 640
[DeepTest] CUBIC Congestion Control Test Suite Enhancement #5685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saikat107
wants to merge
55
commits into
microsoft:main
Choose a base branch
from
saikat107:saikat/cubic-extended
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,347
−37
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
1a0db75
Add the externs for cubic and bbr
saikat107 fa29423
Merge branch 'main' of github.com:saikat107/msquic
saikat107 c41da3f
Initial skeleton for cubic test
saikat107 65c12bc
Merge branch 'microsoft:main' into main
saikat107 5fe9b33
Add comprehensive tests for CubicCongestionControlInitialize
saikat107 199a3e4
Complete comprehensive test suite for CubicCongestionControlInitializ…
saikat107 f9a1efc
Refactor test suite: reduce from 21 to 9 unique, well-documented tests
saikat107 a7b16ac
Add 12 more tests via function pointers - coverage improved from 7.96…
saikat107 8bf0fbe
Remove the redundant tests
saikat107 1d445ff
Remove the clog stub and reformat
saikat107 ba8c57f
add the clog files.
saikat107 e1cafa2
Refactor to use real QUIC_CONNECTION
saikat107 271f2aa
Further modify test to improve coverage.
saikat107 637f7af
Added the clog input
saikat107 35441db
34% Coverage
saikat107 6229b63
65% coverage with 38 tests
saikat107 957f3e5
64% coverage with 17 TCs
saikat107 22558f1
Remove the unused variable
saikat107 1cdd3c3
Using DeepTest + Agency to cover 15% of the tests. Remaining require …
madanMus da68d58
adding changes to run the test
madanMus f157b02
adding changes to run the test
madanMus 392e47e
adding more tests
madanMus 68694cd
63% to 69%
saikat107 e70f857
77.5% coverage with 32 test cases.
saikat107 20d047b
77.5% coverage with 24 test cases
saikat107 791e7d1
Improved coverage slightly with 26 test cases
saikat107 708c322
Addressing some of the feedback
saikat107 a15419d
Trigger CI
saikat107 cc8ab0e
Change the ExpectedPacedAllowance to be pre-calculated value.
saikat107 b965e0a
Merge branch 'microsoft:main' into saikat/cubic
saikat107 9adaf9f
Merge branch 'saikat/cubic' of github.com:saikat107/msquic into saika…
saikat107 dc74427
Remove zero assertions.
saikat107 f2c386f
Merge branch 'saikat/cubic' into saikat/cubic-extended
saikat107 572d1c7
Sync with the PR changes
saikat107 3705277
82% coverage with 25 tests
saikat107 b80da7b
84% coverage with 25 tests
saikat107 3da3f7b
88.8% with 32 tests
saikat107 e4aeafb
94% coverage with 37 tests
saikat107 41ee643
95% coverage with 40 tests.
saikat107 6d2c94c
96% coverage with 41 tests
saikat107 185b107
96% coverage with 39 tests
saikat107 f5d5e86
Some refactoring
saikat107 f8ce390
Refactoring
saikat107 4cc5157
96.2%
saikat107 f2a78b9
Edit annotations
saikat107 017c17a
Merge branch 'main' of github.com:saikat107/msquic
saikat107 408703e
Merge branch 'main' into saikat/cubic-extended
saikat107 94468e0
Remove BBR test for now.
saikat107 f5c683a
Delete the deeptest internal file
saikat107 248aae0
Revert Congestion control to original version
saikat107 8e9123a
Remove the EOL from congestion control.h
saikat107 e492129
Remove unused variable.
saikat107 4e34b42
99.41% Coverage
saikat107 d9af4b8
Remove unused variables.
saikat107 f660d87
Merge branch 'main' of https://github.com/microsoft/msquic into saika…
saikat107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -411,4 +411,4 @@ QuicCongestionControlSetAppLimited( | |
| ) | ||
| { | ||
| Cc->QuicCongestionControlSetAppLimited(Cc); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we try to keep the end of file carriage return