Skip to content

Fix reentrant assert failures in session resumption with custom executions #5844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leikong wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix reentrant assert failures in session resumption with custom executions #5844

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
299880a
Fix reentrant bugcheck in SetParam(RESUMPTION_TICKET) with custom exe…
leikong Mar 3, 2026
99e5e97
Fix reentrant bugcheck for datagram state change in SetParam(RESUMPTI…
leikong Mar 4, 2026
fef99c3
Defer notifications instead of skipping during resumption ticket proc…
leikong Mar 4, 2026
9467c26
Rename FlushIfUnblocked to FromResumptionTicket
leikong Mar 5, 2026
2912976
Merge remote-tracking branch 'origin/main' into kong/fix.retrentrant.…
leikong Mar 5, 2026
07a6866
Relax reentrant assertion for custom executions instead of queuing no…
leikong Mar 11, 2026
b2c600d
Also relax reentrant assertion in QuicStreamIndicateEvent for custom …
leikong Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/core/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3089,7 +3089,9 @@ QuicConnProcessPeerTransportParameters(
Connection->PeerTransportParams.InitialMaxUniStreams,
!FromResumptionTicket);

QuicDatagramOnSendStateChanged(&Connection->Datagram);
if (!FromResumptionTicket) {
QuicDatagramOnSendStateChanged(&Connection->Datagram);
}

if (Connection->State.Started) {
if (Connection->State.Disable1RttEncrytion &&
Expand Down
2 changes: 1 addition & 1 deletion src/core/stream_set.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ QuicStreamSetInitializeTransportParameters(
}
}

if (UpdateAvailableStreams) {
if (UpdateAvailableStreams && FlushIfUnblocked) {
QuicStreamSetIndicateStreamsAvailable(StreamSet);
}

Expand Down
Loading