Improve support for custom OpenSSL selection#5848
Open
masa-koz wants to merge 2 commits intomicrosoft:mainfrom
Open
Improve support for custom OpenSSL selection#5848masa-koz wants to merge 2 commits intomicrosoft:mainfrom
masa-koz wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5848 +/- ##
==========================================
- Coverage 86.30% 84.89% -1.41%
==========================================
Files 60 60
Lines 18732 18732
==========================================
- Hits 16167 15903 -264
- Misses 2565 2829 +264 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces improved support for building with an external OpenSSL installation, primarily by adding a new
openssl_externalfeature and enhancing the build system to handle more flexible OpenSSL configuration. The changes affect CMake configuration, Rust feature flags, and build scripts to better support both static and shared linking, and to allow specifying OpenSSL paths via environment variables.Build system and CMake improvements:
QUIC_OPENSSL_ROOT_DIRto allow specifying the OpenSSL root directory, and updated OpenSSL selection logic to support this variable for both static and shared builds. [1] [2]BUILD_SHARED_LIBSflag, and improved handling of imported OpenSSL targets to avoid duplicate dependency linking.Rust feature and build script updates:
openssl_externalfor building with an external OpenSSL, and updated the build script (scripts/build.rs) to configure CMake accordingly by passing the appropriate variables from environment variables if set. [1] [2]libon Windows andartifactselsewhere, improving compatibility with different platforms.Test and platform compatibility:
src/rs/config.rsto recognize the newopenssl_externalfeature when determining which TLS provider is active on Windows.Testing
No
Documentation
TBD