Skip to content

Add rust build link dependencies#5854

Merged
guhetier merged 2 commits intomainfrom
guhetier/fix_rust_build
Mar 10, 2026
Merged

Add rust build link dependencies#5854
guhetier merged 2 commits intomainfrom
guhetier/fix_rust_build

Conversation

@guhetier
Copy link
Collaborator

@guhetier guhetier commented Mar 9, 2026

Description

Fixes the Rust CI failures

AI diagnostic

Root Cause: Accidental Transitive Dependency

Cargo.lock is .gitignore'd, so every CI run resolves the latest compatible dependency versions. Between Mar 5 and Mar 6:

  1. socket2 updated 0.6.2 →
    0.6.3, which bumped windows-sys from 0.60.2 → 0.61.2
  2. windows-sys
    0.60.x depended on windows_x86_64_msvc — a crate that ships actual .lib import library files (advapi32.lib, crypt32.lib, iphlpapi.lib, etc.) and makes them available to the linker
  3. windows-sys
    0.61.x switched to windows-link with raw-dylib, which generates import stubs inline — dropping windows_x86_64_msvc entirely
  4. The msquic build.rs never declared its Windows system library dependencies — they were accidentally satisfied by windows_x86_64_msvc's import libraries being on the linker search path
  5. With that crate gone, msquic.lib's references to advapi32, crypt32, etc. became unresolved

Testing

CI

Documentation

N/A

@guhetier guhetier marked this pull request as ready for review March 9, 2026 20:45
@guhetier guhetier requested a review from a team as a code owner March 9, 2026 20:45
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.87%. Comparing base (45a46f3) to head (c2c6df1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5854      +/-   ##
==========================================
- Coverage   86.30%   84.87%   -1.44%     
==========================================
  Files          60       60              
  Lines       18732    18732              
==========================================
- Hits        16167    15899     -268     
- Misses       2565     2833     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guhetier guhetier enabled auto-merge (squash) March 10, 2026 00:10
@guhetier guhetier merged commit acf0b8f into main Mar 10, 2026
579 of 581 checks passed
@guhetier guhetier deleted the guhetier/fix_rust_build branch March 10, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants