FEAT: Support 5.2- Added JSONARRAY Feature Support#460
Merged
NandanaRaol merged 3 commits intodevfrom Jun 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Django 5.2 and Python 3.13 while introducing a new SQL Server–specific implementation for the JSONArray function.
- Updates tox.ini, setup.py, and Azure Pipelines configuration to include Django 5.2 and Python 3.13 testing.
- Implements a new SQL Server function (sqlserver_json_array) to handle JSONArray operations with support for nested JSON structures and multiple data types.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tox.ini | Added Django 5.2 testing environments and updated dependency declarations. |
| setup.py | Updated classifiers and Django dependency range to support Django 5.2. |
| mssql/functions.py | Introduced SQL Server JSONArray implementation and registered it for Django 5.2. |
| azure-pipelines.yml | Updated build matrix to run tests against Django 5.2 with various Python versions. |
Comments suppressed due to low confidence (1)
mssql/functions.py:235
- [nitpick] Consider passing numeric values in their native type instead of converting them to strings, unless the intended SQL parameter type requires string conversion.
params.append(str(val))
52bb9fd to
ad12745
Compare
bewithgaurav
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for Django 5.2 and Python 3.13, alongside adding a new SQL Server-specific implementation for the
JSONArrayfunction. Key changes span updates to CI configurations, dependency declarations, and the implementation of the new database function.Support for Django 5.2 and Python 3.13:
azure-pipelines.yml: Added new matrix configurations for Django 5.2 with Python versions 3.10 through 3.13 to ensure compatibility testing. [1] [2]setup.py: Updated classifiers to include Django 5.2 and Python 3.13, and extended the Django dependency range to<5.3. [1] [2]tox.ini: Added Django 5.2 to theenvlistand defined its dependency range. [1] [2]New SQL Server
JSONArrayImplementation:mssql/functions.py: Introduced thesqlserver_json_arrayfunction to handle theJSONArrayoperation for SQL Server, including support for nested JSON structures and various data types. Registered this implementation for Django 5.2 and above. [1] [2]