FIX: Exclude testapp from package distribution#503
Open
robberwick wants to merge 1 commit intomicrosoft:devfrom
Open
FIX: Exclude testapp from package distribution#503robberwick wants to merge 1 commit intomicrosoft:devfrom
robberwick wants to merge 1 commit intomicrosoft:devfrom
Conversation
find_packages() is called without exclusions in setup.py, causing testapp to be installed as a top-level package alongside mssql into site-packages. This creates namespace collisions for downstream projects that define their own testapp. Add exclude=['testapp', 'testapp.*'] to find_packages() to prevent this.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a packaging issue where the testapp directory (used for testing mssql-django) was being incorrectly included in the package distribution, causing namespace collisions for downstream projects that define their own testapp.
Changes:
- Add exclusion pattern to
find_packages()in setup.py to prevent testapp and its subpackages from being distributed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502
find_packages() is called without exclusions in setup.py, causing testapp to be
installed as a top-level package alongside mssql into site-packages. This creates namespace collisions for downstream projects that define their own testapp.
Add exclude=['testapp', 'testapp.*'] to find_packages() to prevent this.