Adding OS, architecture and runtime details to applicationName #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
reviewed
Mar 4, 2025
| @@ -170,7 +170,7 @@ public void setApplicationName(String applicationName) { | |||
| @Override | |||
| public String getApplicationName() { | |||
| return getStringProperty(connectionProps, SQLServerDriverStringProperty.APPLICATION_NAME.toString(), | |||
| SQLServerDriverStringProperty.APPLICATION_NAME.getDefaultValue()); | |||
| SQLServerDriver.constructedAppName); | |||
There was a problem hiding this comment.
As decided to make a change only for interfaceLibName, let us keep the application name unchanged everywhere.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
============================================
- Coverage 51.54% 51.51% -0.03%
- Complexity 3996 4001 +5
============================================
Files 147 147
Lines 33694 33731 +37
Branches 5630 5641 +11
============================================
+ Hits 17366 17377 +11
- Misses 13877 13895 +18
- Partials 2451 2459 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enhancing telemetry for SQL drivers, we can achieve a more nuanced understanding of the operating environments in use. This capability enables us to make strategic decisions about testing and support, ultimately improving our efficiency and reducing costs. Adopting a structured approach to telemetry collection will ensure we gather the most relevant and useful data, facilitating continuous improvement in our processes.
Format
{Driver Name}|{OS Type}|{Process Architecture}|{OS Details}|{Runtime Details}
Maximum lengths (in Unicode characters) for each field are:
Driver Name - 16
OS Type - 10
Process Architecture - 10
OS Details - 44
Runtime Details - 44