-
Notifications
You must be signed in to change notification settings - Fork 438
POC: Improve JDBC driver performance using ByteBufferManager for TDS packet handling #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ananya2
wants to merge
5
commits into
main
Choose a base branch
from
users/anagarg/perf-improvement-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
172cf59
Optimized memory usage for TDS packets using ByteBufferManager and Bu…
Ananya2 a53abd1
refactor: instantiated ByteBufferManager in TDSReader and injected in…
Ananya2 23fe04f
fixed failure
Ananya2 79b4b72
fixed pipeline failure
Ananya2 30dd55e
updated code as per review comment
Ananya2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
src/main/java/com/microsoft/sqlserver/jdbc/BufferPool.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package com.microsoft.sqlserver.jdbc; | ||
|
||
import java.util.Arrays; | ||
import java.util.concurrent.ConcurrentLinkedQueue; | ||
|
||
public class BufferPool { | ||
private final int bufferSize; | ||
private final ConcurrentLinkedQueue<byte[]> pool = new ConcurrentLinkedQueue<>(); | ||
|
||
BufferPool(int bufferSize) { | ||
this.bufferSize = bufferSize; | ||
} | ||
|
||
public byte[] rent() { | ||
byte[] buffer = pool.poll(); | ||
return buffer == null ? new byte[bufferSize] : buffer; | ||
} | ||
|
||
public void release(byte[] buffer) { | ||
if (buffer.length == bufferSize) { | ||
pool.offer(buffer); | ||
Arrays.fill(buffer, (byte) 0); // Clear the array for re-use | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to clear the buffer first, then put it pool. You lose ownership once added to pool and another thread might take the buffer, you can't touch it any more. |
||
} | ||
// If the buffer size does not match, we do not store it in the pool | ||
} | ||
} |
42 changes: 42 additions & 0 deletions
42
src/main/java/com/microsoft/sqlserver/jdbc/ByteBufferManager.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
package com.microsoft.sqlserver.jdbc; | ||
|
||
import java.util.concurrent.ConcurrentHashMap; | ||
|
||
public class ByteBufferManager { | ||
|
||
private static int[] poolSizes = { 1024, 2048, 4096, 8192, 16384, 32768, 65536 }; | ||
private final static ConcurrentHashMap<Integer, BufferPool> pools = new ConcurrentHashMap<>(); | ||
|
||
public ByteBufferManager() { | ||
for (int size : poolSizes) { | ||
pools.put(size, new BufferPool(size)); | ||
} | ||
} | ||
|
||
public byte[] rentBytes(int size) { | ||
int poolSize = getPoolSize(size); | ||
|
||
if (poolSize == -1) { | ||
return new byte[size]; | ||
} | ||
BufferPool pool = pools.computeIfAbsent(poolSize, BufferPool::new); | ||
return pool.rent(); | ||
} | ||
|
||
private static int getPoolSize(int size) { | ||
if (size <= 0) return 1024; | ||
|
||
int nextPower = Integer.highestOneBit(size - 1) << 1; | ||
return nextPower <= 65536 ? nextPower : -1; | ||
} | ||
|
||
// Return a previously rented byte array | ||
public void release(byte[] array) { | ||
int size = array.length; | ||
BufferPool pool = pools.get(size); | ||
if (pool != null) { | ||
pool.release(array); | ||
} | ||
// else discard — no pooling for this size | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.