Skip to content

Conversation

muskan124947
Copy link
Contributor

@muskan124947 muskan124947 commented Aug 27, 2025

Reverts #2705

This change is being reverted due to differences in behavior observed between:

- getProcedures() vs getProcedureColumns()
- getFunctions() vs getFunctionColumns()

Specifically:

  • getProcedures() and getFunctions() return procedure/function names without numbered suffixes, since sys.all_objects does not expose numbered procedures.

  • In contrast, getProcedureColumns() and getFunctionColumns() query sp_sproc_columns, which does return numbered procedures, leading to inconsistencies across these APIs.

There was an effort done to make getProcedureColumns() and getFunctionColumns() work in PR#2743.
This PR addressed these differences, but SQL Server still supports numbered procedures, and users can benefit from grouped procedures (see here : sp_proc_columns)

To maintain compatibility and avoid unexpected discrepancies, this PR reverts #2705 and restores the original behavior.

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.51%. Comparing base (e1acc9e) to head (61b4bfd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2751      +/-   ##
============================================
- Coverage     51.51%   51.51%   -0.01%     
+ Complexity     4081     4066      -15     
============================================
  Files           149      149              
  Lines         34268    34241      -27     
  Branches       5725     5718       -7     
============================================
- Hits          17654    17638      -16     
+ Misses        14125    14113      -12     
- Partials       2489     2490       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@muskan124947 muskan124947 added this to the 13.2.1 milestone Aug 27, 2025
@muskan124947 muskan124947 merged commit 245dbe1 into main Aug 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants