Skip to content

Conversation

@ksaye
Copy link
Contributor

@ksaye ksaye commented Mar 11, 2025

3 basic changes:

  1. added an aisearchonly module to create Azure AI Search early in the process
  2. made aisearch dependent on aisearchonly and passed the required variables
  3. added the --no-wait switch when applying the no public access on aisearch

this change reduces the deployment time from 26 minutes to 19 minutes

@ksaye ksaye changed the title Update to speed aisearch deploy Update to speed aisearch deployment Mar 11, 2025
@ksaye
Copy link
Contributor Author

ksaye commented Mar 11, 2025

#204

@ksaye ksaye marked this pull request as ready for review April 22, 2025 14:01
@ksaye
Copy link
Contributor Author

ksaye commented May 20, 2025

Ready for testing

@ksaye
Copy link
Contributor Author

ksaye commented Jun 5, 2025

Moving to draft as other workloads have taking priority.

The initial issue is that the allowed client application on the skill is set to the object id of search and not the client id:
image

This is because the outputs.tf of aisearchonly: https://github.com/microsoft/multimodal-ai/blob/speed-aisearch-deploy/deployment/terraform/infra/modules/aisearch/searchonly/outputs.tf#L20 does not reference the correct client_id

This var is used here: https://github.com/microsoft/multimodal-ai/blob/speed-aisearch-deploy/deployment/terraform/infra/service.tf#L308

If I manually changed it via the portal or disable auth on the skill, it works fine.

If I change it in code to match what was originally done: https://github.com/microsoft/multimodal-ai/blob/main/deployment/terraform/infra/modules/aisearch/outputs.tf#L21 I get a notfound error:

image

@ksaye ksaye marked this pull request as draft June 5, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant