Ensure 755 permissions on prebuild spawn-helper #858
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszomoru
approved these changes
Jan 3, 2026
devm33
reviewed
Jan 10, 2026
| process.exit(1); | ||
| } | ||
|
|
||
| // Ensure spawn-helper has execute permission (may be stripped by npm pack) |
Contributor
There was a problem hiding this comment.
Confused by this. Seems to only happen on darwin-x64 and wasn't happening previously. Is npm pack definitely at fault?
Member
Author
There was a problem hiding this comment.
Opus might have been lying about it due to leading. We should remove this anyway and go with the pipeline approach in https://github.com/microsoft/node-pty/pull/866/changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850
Planning on verifying when a beta build goes out
cc @devm33