Skip to content

Fix CLOSE_RANGE_CLOEXEC build error on Alpine #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzhao271 merged 5 commits into from
Jan 13, 2026
Merged

Fix CLOSE_RANGE_CLOEXEC build error on Alpine #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f4d471
Initial plan
Copilot Jan 13, 2026
41eda9b
Define CLOSE_RANGE_CLOEXEC for Alpine compatibility
Copilot Jan 13, 2026
4d2751d
Final verification complete
Copilot Jan 13, 2026
d85b637
Add CodeQL symlink to gitignore
Copilot Jan 13, 2026
fd2eea6
Check for CLOSE_RANGE_CLOEXEC instead of defining it
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ fixtures/space folder/
.vscode/ipch/
yarn.lock
prebuilds/
_codeql_detected_source_root
2 changes: 1 addition & 1 deletion src/unix/pty.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ SetCloseOnExec(int fd) {
static void
pty_close_inherited_fds() {
// Try close_range() first (Linux 5.9+, glibc 2.34+)
#if defined(SYS_close_range)
#if defined(SYS_close_range) && defined(CLOSE_RANGE_CLOEXEC)
if (syscall(SYS_close_range, 3, ~0U, CLOSE_RANGE_CLOEXEC) == 0) {
return;
}
Expand Down