Move observer triggered team owner/member sync for individual users to ad-hoc tasks#3040
Open
weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
Open
Move observer triggered team owner/member sync for individual users to ad-hoc tasks#3040weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
weilai-irl wants to merge 1 commit intoMOODLE_500_STABLEfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Microsoft 365 group membership synchronization for individual users from synchronous observer-triggered calls to asynchronous ad-hoc tasks. The change improves performance and resilience by offloading potentially slow Microsoft Graph API calls to the task queue rather than blocking during Moodle event processing.
Changes:
- Created new
usergroupmembershipsyncad-hoc task to handle individual user-course group membership synchronization - Updated four event observers (user_enrolment_updated, enrol_instance_updated, role_assigned, role_unassigned) to queue ad-hoc tasks instead of making synchronous API calls
- Added language string for the new task name
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| local/o365/version.php | Updated plugin version number to 2025040820.02 |
| local/o365/lang/en/local_o365.php | Added language string 'task_usergroupmembershipsync' for the new ad-hoc task |
| local/o365/classes/task/usergroupmembershipsync.php | New ad-hoc task class that syncs a single user's role in a course group to Microsoft 365 |
| local/o365/classes/observers.php | Modified four event handlers to queue ad-hoc tasks instead of calling sync_user_role_in_course_group directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
852708a to
a89125e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.