Move observer triggered team owner/member sync for individual users to ad-hoc tasks#3041
Open
weilai-irl wants to merge 1 commit intoMOODLE_501_STABLEfrom
Open
Move observer triggered team owner/member sync for individual users to ad-hoc tasks#3041weilai-irl wants to merge 1 commit intoMOODLE_501_STABLEfrom
weilai-irl wants to merge 1 commit intoMOODLE_501_STABLEfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors observer-triggered Microsoft 365 group/team membership synchronization from synchronous inline operations to asynchronous ad-hoc tasks. When Moodle events fire (user enrollment updates, role assignments/unassignments, enrollment instance updates), instead of immediately calling the Microsoft Graph API to sync the user's role in the connected Microsoft 365 group, the code now queues lightweight ad-hoc tasks that execute later.
Changes:
- Created new ad-hoc task class
usergroupmembershipsyncthat encapsulates single user-course sync logic - Updated four observer methods to queue ad-hoc tasks instead of performing synchronous API calls
- Added language string for the new task
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| local/o365/version.php | Incremented plugin version number (contains a critical formatting issue) |
| local/o365/lang/en/local_o365.php | Added language string for the new ad-hoc task |
| local/o365/classes/task/usergroupmembershipsync.php | New ad-hoc task that syncs a single user's role in a course group to Microsoft 365 |
| local/o365/classes/observers.php | Refactored four observer methods to queue ad-hoc tasks instead of synchronous sync calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
561f076 to
2adf954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.