Prevent unnecessary precision change in upgrade script#3044
Open
weilai-irl wants to merge 1 commit intoMOODLE_501_STABLEfrom
Open
Prevent unnecessary precision change in upgrade script#3044weilai-irl wants to merge 1 commit intoMOODLE_501_STABLEfrom
weilai-irl wants to merge 1 commit intoMOODLE_501_STABLEfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the local/o365 plugin upgrade step to avoid running change_field_precision() when the target column lengths already match the desired schema, and to work around indexed-field precision changes.
Changes:
- Add column-length checks via
$DB->get_columns()to skip unnecessary precision changes. - Drop the
objectidindex before alteringobjectidprecision onlocal_o365_groups_cacheandlocal_o365_teams_cache.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
weilai-irl
force-pushed
the
wip-126138-m501
branch
from
ea8de12 to
f50132f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.