Skip to content

Fix transformers_and_bert arguments #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix transformers_and_bert arguments #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e643153
Fix arguments for transformers_and_bert
sgallese Aug 1, 2024
afa9a37
Add test
sgallese Aug 1, 2024
c1c57eb
Merge branch 'main' into fix-transformers_and_bert-arguments
sgallese Aug 6, 2024
5fef267
Merge branch 'main' into fix-transformers_and_bert-arguments
sgallese Aug 16, 2024
383def2
Merge branch 'main' into fix-transformers_and_bert-arguments
sayanshaw24 Sep 4, 2024
ed09a5a
Merge branch 'main' into fix-transformers_and_bert-arguments
sgallese Sep 5, 2024
af8aff7
Merge branch 'main' into fix-transformers_and_bert-arguments
sgallese Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxruntime_extensions/tools/add_pre_post_processing_to_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ def main():
else:
if args.vocab_file is None or args.nlp_task_type is None or args.tokenizer_type is None:
parser.error("Please provide vocab file/nlp_task_type/tokenizer_type.")
transformers_and_bert(model_path, new_model_path, args.tokenizer_type, args.vocab_file, args.nlp_task_type)
transformers_and_bert(model_path, new_model_path, args.vocab_file, args.tokenizer_type, args.nlp_task_type)


if __name__ == "__main__":
Expand Down
7 changes: 7 additions & 0 deletions test/test_tools_add_pre_post_processing_to_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,13 @@ def test_qatask_with_tokenizer(self):

self.assertEqual(result[0][0], ref_output[0][0])

def test_transformers_and_bert(self):
input_model = os.path.join(test_data_dir, "../bert_qa_decoder_base.onnx")
output_model = (self.temp4onnx / "bert_qa.updated.onnx").resolve()
vocab_file = os.path.join(test_data_dir, "../bert.vocab")

add_ppp.transformers_and_bert(Path(input_model), Path(output_model), Path(vocab_file), "BertTokenizer", "QuestionAnswering")

# Corner Case
def test_debug_step(self):
import onnx
Expand Down