[MIGraphX EP] Syncing AMD changes upstream #25583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIGraphX has enabled this support as part of the latest release. This allows Onnxruntime MIGraphX EP to parse in Attention and SkipLayernormalization operators and pass them to the MIGraphX API for further processing Co-authored-by: Ted Themistokleous <[email protected]>
snnn
previously requested changes
Jul 30, 2025
Member
snnn
left a comment
snnn
left a comment
There was a problem hiding this comment.
Please avoid adding new functions the public C API header file. All the EPs should use SessionOptionsAppendExecutionProvider_V2 to set the options.
snnn
reviewed
Jul 30, 2025
snnn
reviewed
Jul 30, 2025
skottmckay
previously approved these changes
Aug 7, 2025
skottmckay
dismissed
snnn’s stale review
ORT C header only has changes to comments now.
nieubank
previously approved these changes
Aug 7, 2025
skottmckay
reviewed
Aug 7, 2025
Co-authored-by: Scott McKay <[email protected]>
skottmckay
approved these changes
Aug 7, 2025
nieubank
approved these changes
Aug 7, 2025
Contributor
|
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Linux QNN CI Pipeline |
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 5 pipeline(s). |
Contributor
|
/azp run Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adrianlizarraga
approved these changes
Aug 8, 2025
adrianlizarraga
pushed a commit
that referenced
this pull request
Aug 9, 2025
A set of changes required for WCR/WindowsML that were added to the MIGraphX Execution provider. The development was done in the ROCm repository, now we want to sync with the main branch with a single drop. The PR incorporates the review comments from the previous closed PR #25338. Motivation and Context Fixes, changes, and updates to MIGraphX EP that have been done for ROCm development. Pushing this back upstream to ensure mainline onnxruntime is using the latest changes. Moving forward, MIGraphX EP will be cut from the latest official release tag as a base point while also adding additional features that will be contributed back. --------- Co-authored-by: urpetkov-amd <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Scott McKay <[email protected]>
jywu-msft
pushed a commit
that referenced
this pull request
Aug 9, 2025
### Description Cherry-pick the following PRs into `rel-1.23.0`: - #25629 - #25583 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Chunye Wang@AMD <[email protected]> Co-authored-by: mingyue <[email protected]> Co-authored-by: Artur Wojcik <[email protected]> Co-authored-by: urpetkov-amd <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Scott McKay <[email protected]>
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
A set of changes required for WCR/WindowsML that were added to the MIGraphX Execution provider. The development was done in the ROCm repository, now we want to sync with the main branch with a single drop. The PR incorporates the review comments from the previous closed PR microsoft#25338. Motivation and Context Fixes, changes, and updates to MIGraphX EP that have been done for ROCm development. Pushing this back upstream to ensure mainline onnxruntime is using the latest changes. Moving forward, MIGraphX EP will be cut from the latest official release tag as a base point while also adding additional features that will be contributed back. --------- Co-authored-by: urpetkov-amd <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Scott McKay <[email protected]>
gedoensmax
pushed a commit
to gedoensmax/onnxruntime
that referenced
this pull request
Sep 2, 2025
A set of changes required for WCR/WindowsML that were added to the MIGraphX Execution provider. The development was done in the ROCm repository, now we want to sync with the main branch with a single drop. The PR incorporates the review comments from the previous closed PR microsoft#25338. Motivation and Context Fixes, changes, and updates to MIGraphX EP that have been done for ROCm development. Pushing this back upstream to ensure mainline onnxruntime is using the latest changes. Moving forward, MIGraphX EP will be cut from the latest official release tag as a base point while also adding additional features that will be contributed back. --------- Co-authored-by: urpetkov-amd <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Scott McKay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of changes required for WCR/WindowsML that were added to the MIGraphX Execution provider. The development was done in the ROCm repository, now we want to sync with the main branch with a single drop.
The PR incorporates the review comments from the previous closed PR #25338.
Motivation and Context
Fixes, changes, and updates to MIGraphX EP that have been done for ROCm development. Pushing this back upstream to ensure mainline onnxruntime is using the latest changes. Moving forward, MIGraphX EP will be cut from the latest official release tag as a base point while also adding additional features that will be contributed back.