safeint.h: quelch gcc's -Wreturn-type #25655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-type The `SafeIntOn*` member functions immediately throw, so if they are used in a function with non-void return type, g++ 14 issues a warning that there exist control paths in the function where no value is returned. Quoting cppreference.com: (the `[[noreturn]]` attribute) Indicates that the function will not return control flow to the calling function after it finishes (e.g. functions that terminate the application, throw exceptions, loop indefinitely, etc.). This attribute applies to the name of the function being declared in function declarations only. If a function previously declared with `[[noreturn]]` is invoked and that invocation eventually returns, the behavior is runtime-undefined. Fix this by marking the member functions explicitly noreturn.
|
Notably, in |
snnn
approved these changes
Aug 6, 2025
|
/azp run Windows x64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows ARM64 QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Linux QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
gedoensmax
pushed a commit
to gedoensmax/onnxruntime
that referenced
this pull request
Sep 2, 2025
Quoting cppreference.com: ``` (the [[noreturn]] attribute) Indicates that the function will not return control flow to the calling function after it finishes (e.g. functions that terminate the application, throw exceptions, loop indefinitely, etc.). This attribute applies to the name of the function being declared in function declarations only. If a function previously declared with `[[noreturn]]` is invoked and that invocation eventually returns, the behavior is runtime-undefined. ``` The `SafeIntOn*` member functions immediately throw, so if they are used in a function with non-void return type, g++ 14 issues a warning that there exist control paths in the function where no value is returned. Fix this by marking the member functions explicitly noreturn. This is needed so onnxruntime builds correctly with `-Wall -Wextra`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting cppreference.com:
The
SafeIntOn*member functions immediately throw, so if they are used in a function with non-void return type, g++ 14 issues a warning that there exist control paths in the function where no value is returned.Fix this by marking the member functions explicitly noreturn.
This is needed so onnxruntime builds correctly with
-Wall -Wextra.