Skip to content

Conversation

yuslepukhin
Copy link
Member

This pull request introduces a minor update to the test infrastructure and test files, focusing on improving build configuration and test utility usage.

Build configuration:

  • Updated cmake/onnxruntime_test_pch.cmake to only enable precompiled headers for test targets when not performing a minimal build, preventing unnecessary PCH usage in minimal build scenarios.

Test utility improvements:

  • Added an include for asserts.h in onnxruntime/test/platform/file_io_test.cc, ensuring test assertions are available and improving test reliability.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the minimal build configuration by preventing unnecessary precompiled header (PCH) usage and adding missing test utilities. The changes ensure that minimal builds can complete successfully without PCH overhead while maintaining proper test infrastructure.

  • Conditional precompiled header usage for test targets in minimal builds
  • Added missing test assertion include to file_io_test.cc

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
cmake/onnxruntime_test_pch.cmake Wraps PCH configuration in minimal build check to prevent PCH usage during minimal builds
onnxruntime/test/platform/file_io_test.cc Adds missing asserts.h include for test utilities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

snnn
snnn previously approved these changes Oct 3, 2025
@yuslepukhin yuslepukhin closed this Oct 7, 2025
@yuslepukhin yuslepukhin reopened this Oct 7, 2025
@yuslepukhin yuslepukhin merged commit def8a93 into main Oct 7, 2025
169 of 170 checks passed
@yuslepukhin yuslepukhin deleted the yuslepukhin/fix_minimal_build branch October 7, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants