-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Adding SME1 Convolution Kernel to convole_kleidiai.cpp #26402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SME1 Convolution Kernel to convole_kleidiai.cpp #26402
Conversation
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Can you please re-base ? @JonathanC-ARM |
Signed-off-by: Jonathan Clohessy <[email protected]>
b49e63e to
20ce3f1
Compare
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Can you please confirm if the corresponding tests passed on an SME1 machine or using SME1 mode on an SME2 machine ? |
Signed-off-by: Jonathan Clohessy <[email protected]>
Signed-off-by: Jonathan Clohessy <[email protected]>
|
Hi Hari, yeah so I've one push to come fixing the sme2 checks. These are going to be changed subsequently via the gemv pr anyway but in the meantime you are correct its right to fix them now. The sme1 tests pass also, we test on both sme2 and sme1. We typically force sme2 to be false to verify these kernels during development. Please see attached output of the tests for ort test all and mlas tests. Both of which pass and in the case of mlas tests we see that there are a few hundred skipped tests with a message "MlasDynamicQGemmBatch() requires ARM64 SME2 but it was not detected. Skipping test." |
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Description