Log filesystem path instead of string for C++20 compliance#26745
Open
JanSellner wants to merge 2 commits intomicrosoft:mainfrom
Open
Log filesystem path instead of string for C++20 compliance#26745JanSellner wants to merge 2 commits intomicrosoft:mainfrom
JanSellner wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Author
|
@skottmckay Anything I can do to move forward with this (small) PR? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a C++20 compliance issue in the LoadPluginOrProviderBridge function where a wchar_t* string (represented as ORTCHAR_T* on Windows) was being logged to std::ostream, which is not allowed in C++20. The fix changes the logging statement to use the std::filesystem::path object instead.
Changes:
- Updated logging statement to use
resolved_library_path(std::filesystem::path) instead oflibrary_path(ORTCHAR_T*) for C++20 compliance
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skottmckay
approved these changes
Feb 16, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26745 in repo microsoft/onnxruntime |
Author
|
Hmm, worth a try :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Log the
std::filesystem::pathobject instead of theORTCHAR_Tstring to avoid C++20 compliance issues.Motivation and Context
ORTCHAR_Tis awchar_ton Windows and it is not allowed to pass that tostd::basic_ostream.Example
(example.cpp)
Output on latest MSVC with
/std:c++20: