GPG changed default install location on 12/31/2025 for Windows

[eserscor]

Description

Update search for GPG to check for both Program Files and Program Files (x86)

Motivation and Context

[github-actions]

You can commit the suggested changes from lintrunner.

[github-actions]

You can commit the suggested changes from lintrunner.

[tianleiwu]

The PR addresses GPG signing issues in the Windows CI environment for Java artifacts. It improves the robustness of locating the gpg.exe binary and adds a cleanup step for the GPG trust database to prevent potential corruption or stale state issues.

Detailed Review

tools/ci_build/github/windows/sign_java_artifacts.py

1. GPG Path Detection (get_gpg_path)

• The update to search for gpg.exe in both %ProgramFiles(x86)% and %ProgramFiles% is a good addition. As noted in the comments, the tool installation location can vary (e.g., changed on 12/31/2025). This makes the script more resilient.

2. TrustDB Cleanup (clean_gpg_trustdb)

• clean_gpg_trustdb explicitly removes trustdb.gpg from the APPDATA directory. This is a practical fix for CI environments where state persistence can lead to conflicts.
• Note: The error handling (try...except OSError) prints a warning but allows execution to continue, which is appropriate.

3. Main Execution Flow

• Calling gpg --check-trustdb ensures that the trust database is in a valid state before importing keys.
• Adding --yes to the gpg --import command ensures non-interactive execution.

Conclusion

The changes are well-targeted fixes for the Windows CI environment.