Fix ClipQuantFusion crash when Clip has multiple input edges #26923
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ClipQuantFusion in clip_quantizelinear.cccallsgraph_utils::RemoveNode()without first checkinggraph_utils::CanRemoveNode(). When a Clip node has min/max inputs from DequantizeLinear nodes (instead of initializers), it has multiple input edges.RemoveNode()throws exception:Fix:
Added
CanRemoveNode()check toClipQuantFusion::SatisfyCondition()to skip nodes that cannot be safely removed.Test:
Added
ClipQuantFusion_MultipleInputEdgestest that creates a Clip node with min from a DQ node (2 input edges) and verifies the optimizer doesn't crash.