[MLAS] Removed memcpy step by storing result in C if possible#27367
Merged
hariharans29 merged 1 commit intomicrosoft:mainfrom Feb 17, 2026
Merged
Conversation
Signed-off-by: Jonathan Clohessy <Jonathan.Clohessy@arm.com>
Member
|
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes MLAS KleidiAI's SGEMM implementation by eliminating an unnecessary memcpy step. When alpha=1.0 and beta=0.0, the result is now written directly to the output matrix C instead of first writing to a temporary buffer and then copying.
Changes:
- Simplified the direct-write condition from checking multiple constraints (ldc==TileSizeN, boundary checks, zero size checks) to only checking alpha==1.0 and beta==0.0
- Leverages KleidiAI's run_matmul capability to write directly to non-contiguous output via the row stride parameter
- Eliminates temporary buffer allocation and memcpy when alpha/beta scaling is not needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hariharans29
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the memcpy step in sgemm_kleidiai where possible by writing directly to C
Testing