[IR] Fix an error when checking for float8_e4m3fnuz type in ir.Tensor#2078
Merged
justinchuby merged 1 commit intomainfrom Feb 27, 2025
Merged
[IR] Fix an error when checking for float8_e4m3fnuz type in ir.Tensor#2078justinchuby merged 1 commit intomainfrom
justinchuby merged 1 commit intomainfrom
Conversation
The float8_e4m3fnuz type was mistaken with float8_e4m3b11fnuz, which is a different type: https://github.com/jax-ml/ml_dtypes#float8_e4m3b11fnuz
Contributor
There was a problem hiding this comment.
PR Overview
This PR fixes an error in the type-checking logic for ir.Tensor by correcting an incorrect reference to the float8 type.
- Corrects the mistaken type from ml_dtypes.float8_e4m3b11fnuz to ml_dtypes.float8_e4m3fnuz.
Reviewed Changes
| File | Description |
|---|---|
| onnxscript/ir/_core.py | Updated type check to use the correct float8_e4m3fnuz type |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
onnxscript/ir/_core.py:202
- The incorrect type reference has been replaced with the correct one. Verify that any related type validations across the code are consistent with this change.
ml_dtypes.float8_e4m3fnuz,
❌ 45 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
titaiwangms
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The float8_e4m3fnuz type was mistaken with float8_e4m3b11fnuz, which is a different type: https://github.com/jax-ml/ml_dtypes#float8_e4m3b11fnuz