[Rewriter] Support specifying node name in rewrites

[AyoubMDL]

Allows passing a node name when defining a rewrite. fixes #2435

[AyoubMDL]

Hi @justinchuby, @gramalingam ,
In this PR, I’ve extracted the node name so it can be explicitly set when writing a rewrite. Let me know if you’d like me to apply the same approach to the other "op" parameters as well.
Also, should I make the same change in onnx_ir ?

[justinchuby]

Thanks!

the same approach to the other "op" parameters as well.
Also, should I make the same change in onnx_ir ?

What are the other parameters? What would be the change to onnx ir?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.37%. Comparing base (d0fb218) to head (11a4350).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2474      +/-   ##
==========================================
+ Coverage   70.36%   70.37%   +0.01%     
==========================================
  Files         218      218              
  Lines       26412    26428      +16     
  Branches     2646     2646              
==========================================
+ Hits        18584    18598      +14     
- Misses       6922     6923       +1     
- Partials      906      907       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AyoubMDL]

What are the other parameters?

overload: str = "",
graph: ir.Graph | None = None,
doc_string: str | None = None,
metadata_props: dict[str, str] | None = None,
output: ir.Value | None = None,

I am not sure if output and graph should be added.

What would be the change to onnx ir?

There is the same Builder class https://github.com/onnx/ir-py/blob/fced9bd53e7830d28d0100fb86342d3b578889ec/src/onnx_ir/_tape.py#L177

[justinchuby]

I see. The builder class in onnx-ir is not exposed yet. I want to reason about it's api and verify usage in onnxscript first. So far it's only used in the rewriter. (So no need to update onnx-ir for now)

[justinchuby]

Thank you!