Merged
Conversation
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces layer normalization fusion functionality to optimize ONNX models by fusing layer normalization patterns into the ONNX LayerNormalization operator. This is designed for ONNX opset 17+ where the LayerNormalization operator is available.
Key changes:
- Adds fusion rules to detect and fuse layer normalization patterns with and without bias
- Implements pattern matching for the mathematical sequence of operations that constitute layer normalization
- Includes comprehensive test cases to validate the fusion functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| onnxscript/rewriter/testing.py | Adds utility functions for generating random inputs and enhances numerical equality testing to support dictionary-based inputs |
| onnxscript/rewriter/onnx_fusions/_layer_norm.py | Implements the core layer normalization fusion logic with pattern matching and rewrite rules |
| onnxscript/rewriter/onnx_fusions/_layer_norm_test.py | Provides test cases for layer normalization fusion with and without bias scenarios |
justinchuby
reviewed
Aug 16, 2025
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce layer-norm fusion rules, along with a couple of test cases.
This is just the first version. TO DO: