Skip to content

Fixes for when attr type can be ambiguous for empty lists #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 2 commits into from
Aug 22, 2025
Merged

Fixes for when attr type can be ambiguous for empty lists #2505

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a58482
Fixes for when attr type can be ambiguous for empty lists
justinchuby Aug 21, 2025
deeeba3
Merge branch 'main' into justinchu/attrss
justinchuby Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions onnxscript/optimizer/_constant_folding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def gather(node: ir.Node, op, state: OptimizerState) -> ReturnValue:
if output is not None:
state.set_sym_value(output, ir.Shape(gathered))
if all(isinstance(d, int) for d in gathered):
return op.Constant(value_ints=gathered)
return op.Constant(value_ints=ir.AttrInt64s("value_ints", gathered))
return None


Expand Down Expand Up @@ -466,7 +466,7 @@ def shape(node: ir.Node, op, state: OptimizerState) -> ReturnValue:
if output is not None:
state.set_sym_value(output, ir.Shape(shape_slice))
if all(isinstance(d, int) for d in shape_slice):
return op.Constant(value_ints=list(shape_slice))
return op.Constant(value_ints=ir.AttrInt64s("value_ints", list(shape_slice)))
return None


Expand Down
Loading