Merged
Conversation
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for different multiplication orders in RMS Normalization by creating two variants of the RmsNormFusion rule. The changes allow the pattern matcher to handle both normalized * scale and scale * normalized multiplication orders.
- Parameterizes the RmsNormFusion class to support different multiplication orders
- Creates two separate fusion rules to handle both multiplication patterns
- Updates the ruleset to include both variants for comprehensive pattern matching
justinchuby
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RMS Normalization variant to support both orders for multiplying scale and normalized value.