Skip to content

Fix unicode issue #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 4 commits into from
Jan 8, 2026
Merged

Fix unicode issue #2747

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db863e3
Fix unicode issue
gramalingam Dec 26, 2025
f4837c2
Refactor string decoding and attribute value handling
justinchuby Dec 30, 2025
02c9568
Apply suggestion from @justinchuby
justinchuby Dec 30, 2025
c494888
Update onnx_export.py
justinchuby Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions onnxscript/backend/onnx_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ def _translate_value_info(value_info: ValueInfoProto) -> str:

def _to_str(s):
if isinstance(s, bytes):
return s.decode("utf-8")
try:
return s.decode("utf-8")
except UnicodeDecodeError:
pass
return s


Expand Down Expand Up @@ -391,7 +394,7 @@ def _translate_attributes(self, node):
attributes.append((at.name, at.ref_attr_name))
continue
value = _attribute_value(at)
if isinstance(value, str):
if isinstance(value, str, bytes):
attributes.append((at.name, f"{value!r}"))
continue
if isinstance(value, np.ndarray):
Expand Down
Loading