feat(opentmk): opentmk framework with first testcase #1210
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
|
|
||
| [package] | ||
| name = "opentmk" | ||
| edition.workspace = true | ||
| rust-version.workspace = true | ||
|
|
||
| [features] | ||
| default = ["nightly"] | ||
| nightly = ["x86_64-nightly"] | ||
| x86_64-nightly = ["x86_64/nightly"] | ||
|
|
||
| [dependencies] | ||
|
There was a problem hiding this comment. nit: sort and switch to dotted syntax for crates that don't need features. Also move all crates to be workspaced. There was a problem hiding this comment. @smalis-msft There is one issue where I want to use the serde package with default features off as I want to use a no_std env. Should I disable the feature in workspace? |
||
| arrayvec.workspace = true | ||
| bitfield-struct.workspace = true | ||
| cfg-if.workspace = true | ||
| hvdef = {workspace = true} | ||
| iced-x86 = { workspace = true, features = ["decoder", "nasm", "no_std"]} | ||
| lazy_static = { workspace = true, features = ["spin_no_std"] } | ||
| linked_list_allocator.workspace = true | ||
| log.workspace = true | ||
| memory_range.workspace = true | ||
| minimal_rt.workspace = true | ||
| spin.workspace = true | ||
| serde = { version = "1.0", default-features = false, features = ["derive"]} | ||
| serde_json = { version = "1.0", default-features = false, features = ["alloc"] } | ||
| thiserror.workspace = true | ||
| uefi = { workspace = true, features = ["alloc"] } | ||
| x86_64 = { workspace = true, features = ["instructions"] } | ||
| x86defs.workspace = true | ||
| zerocopy.workspace = true | ||
| nostd_spin_channel.workspace = true | ||
|
|
||
| [lints] | ||
| workspace = true | ||
|
|
||
| [build-dependencies] | ||
| minimal_rt_build.workspace = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # OpenTMK | ||
|
|
||
| See the guide for more info on how to build/run the code in this crate. | ||
smalis-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| RUST_BACKTRACE=1 CARGO_PROFILE_RELEASE_force_frame_pointers=yes cargo build -p opentmk --target x86_64-unknown-uefi --release #--target-dir ./target/x86_64-unknown-uefi/debug | ||
| cargo xtask guest-test uefi --bootx64 ~/projects-local/openvmm/target/x86_64-unknown-uefi/release/opentmk.efi | ||
| qemu-img convert -f raw -O vhdx ~/projects-local/openvmm/target/x86_64-unknown-uefi/release/opentmk.img ~/projects/opentmk.vhdx | ||
| #CARGO_PROFILE_RELEASE_OPT_LEVEL=0 | ||
| #+nightly-2025-05-09 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| imports_granularity = "Item" # Expands `use foo::{bar, baz};` into separate `use` lines | ||
|
There was a problem hiding this comment. This will need to go away, although if these options are stabilized they could move to our root rustfmt.toml. |
||
| reorder_imports = true # Optional: sort imports | ||
| normalize_imports = true # Optional: standardize style (e.g., remove leading ::) | ||
| group_imports = "StdExternalCrate" # Optional: group std/external/local with blank lines | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| /// Writes a synthehtic register to tell the hypervisor the OS ID. | ||
| fn report_os_id(guest_os_id: u64) { | ||
| // On ARM64, to be able to make hypercalls, one needs first to set the Guest OS ID | ||
| // synthetic register using a hypercall. Can't use `Hvcall::set_register` at that will | ||
| // lead to the infinite recursion as that function will first try initializing hypercalls | ||
| // with setting a register. | ||
| // | ||
| // Only one very specific HvSetVpRegisters hypercall is allowed to set the Guest OS ID | ||
| // (this is TLFS section 17.4.4.1.1 and 5.3), and that must be the fast hypercall. | ||
| let _ = minimal_rt::arch::hypercall::set_register_fast( | ||
| hvdef::HvArm64RegisterName::GuestOsId.into(), | ||
| guest_os_id.into(), | ||
| ); | ||
| } | ||
|
|
||
| pub(crate) fn initialize(guest_os_id: u64) { | ||
| // We are assuming we are running under a Microsoft hypervisor. | ||
| report_os_id(guest_os_id); | ||
| } | ||
|
|
||
| /// Call before jumping to kernel. | ||
| pub(crate) fn uninitialize() { | ||
| report_os_id(0); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| pub mod serial; | ||
|
|
||
| pub mod hypercall; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we unify on the same version of spin that lazy_static is pulling in, so we only have the one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will work on versioning and package related changes as I resolve the merge conflicts.