Skip to content

Conversation

@timbze
Copy link

@timbze timbze commented Dec 4, 2024

Here is a PR to do docker build testing and publishing for both NET 8 and 9. I have not tested this as it's not trivial to test without setting up docker hub, secrets, etc.

Fixes #3075

  • 9.0-jammy docker image does not exist. I could just change the 2 .sh scripts to exit gracefully when trying to run for that configuration.

@timbze
Copy link
Author

timbze commented Dec 4, 2024

@microsoft-github-policy-service agree

exit 1
fi

# Set default .NET version to net8 if not specified
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove

@timbze
Copy link
Author

timbze commented Dec 4, 2024

The jammy 8.0 test that failed (only 1) is a timeout and I guess not related to this PR

@mxschmitt
Copy link
Contributor

mxschmitt commented Dec 10, 2024

Thank you for your contribution! We recommend installing it manually on top of our existing image see the docs here since this is a STS version.

@timbze
Copy link
Author

timbze commented Dec 10, 2024

@mxschmitt thank you, I didn't think of it working that simple. Should work for me then.

@Kralizek
Copy link

Thank you for your contribution! We recommend installing it manually on top of our existing image see the docs here since this is a STS version.

A release being STS or LTS shouldn't be a deciding factor imho.

Especially since Microsoft is trying to push the idea that STS and LTS are qualitative equivalent.

@petrikero
Copy link

Just a heads up to others using the recommended approach, the proposed URL https://dot.net/v1/dotnet-install.sh has been quite unreliable and often has downtime. The direct GitHub URL https://raw.githubusercontent.com/dotnet/install-scripts/refs/heads/main/src/dotnet-install.sh is much more reliable.

Another downside of using the install script in your docker files is that it doesn't cache well in CI systems. For example, on GitHub, it takes around 8 seconds. An official .NET 9 image of Playwright would fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support .NET 9 for docker

4 participants