Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/Playwright.Tests/BrowserContextCookiesTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -199,4 +199,37 @@ await Context.AddCookiesAsync(new[]
Assert.IsTrue(cookie.Secure);
Assert.AreEqual(DefaultSameSiteCookieValue, cookie.SameSite);
}

[PlaywrightTest("browsercontext-cookies.spec.ts", "should get cookies from single urls")]
public async Task ShouldGetCookiesFromSingleUrl()
{
await Context.AddCookiesAsync(
[
new Cookie
{
Url = "https://foo.com",
Name = "doggo",
Value = "woofs"
},
]);

void ValidateCookies(IReadOnlyList<BrowserContextCookiesResult> cookies)
{
Assert.AreEqual(1, cookies.Count);
var cookie = cookies[0];
Assert.AreEqual("doggo", cookie.Name);
Assert.AreEqual("woofs", cookie.Value);
Assert.AreEqual("foo.com", cookie.Domain);
Assert.AreEqual("/", cookie.Path);
Assert.AreEqual(cookie.Expires, -1);
Assert.IsFalse(cookie.HttpOnly);
Assert.IsTrue(cookie.Secure);
Assert.AreEqual(DefaultSameSiteCookieValue, cookie.SameSite);
}

ValidateCookies(await Context.CookiesAsync("https://foo.com"));
ValidateCookies(await Context.CookiesAsync(null as string));
ValidateCookies(await Context.CookiesAsync(null as string[]));
ValidateCookies(await Context.CookiesAsync([]));
}
}
4 changes: 2 additions & 2 deletions src/Playwright/Core/BrowserContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -379,14 +379,14 @@ internal void SetOptions(BrowserNewContextOptions contextOptions, string tracesD
public Task<IReadOnlyList<BrowserContextCookiesResult>> CookiesAsync() => CookiesAsync(Array.Empty<string>());

[MethodImpl(MethodImplOptions.NoInlining)]
public Task<IReadOnlyList<BrowserContextCookiesResult>> CookiesAsync(string url) => CookiesAsync(new string[] { url });
public Task<IReadOnlyList<BrowserContextCookiesResult>> CookiesAsync(string url) => CookiesAsync(string.IsNullOrEmpty(url) ? null : [url]);

[MethodImpl(MethodImplOptions.NoInlining)]
public async Task<IReadOnlyList<BrowserContextCookiesResult>> CookiesAsync(IEnumerable<string> urls) => (await SendMessageToServerAsync(
"cookies",
new Dictionary<string, object>
{
["urls"] = urls.ToArray(),
["urls"] = urls ?? [],
}).ConfigureAwait(false))?.GetProperty("cookies").ToObject<IReadOnlyList<BrowserContextCookiesResult>>();

[MethodImpl(MethodImplOptions.NoInlining)]
Expand Down