chore: enable #nullable iteration 1 #3165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
enable-nullable-1
branch
from
06eb101 to
fa3da57
Compare
mxschmitt
force-pushed
the
enable-nullable-1
branch
from
fa3da57 to
9d9cc26
Compare
dgozman
approved these changes
May 22, 2025
| internal static string? ToWebSocketBaseURL(string? baseURL) | ||
| { | ||
| if (string.IsNullOrEmpty(baseURL)) | ||
| if (string.IsNullOrEmpty(baseURL) || baseURL == null) |
Contributor
There was a problem hiding this comment.
Shouldn't IsNullOrEmpty() handle the null case?
Contributor
Author
There was a problem hiding this comment.
Unfortunately not with our tfm: https://stackoverflow.com/a/64066801
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
dgozman
approved these changes
May 22, 2025
yury-s
approved these changes
May 22, 2025
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| public async Task<IBrowser> LaunchAsync(BrowserTypeLaunchOptions options = default) | ||
| public async Task<IBrowser> LaunchAsync(BrowserTypeLaunchOptions? options = default) |
Member
There was a problem hiding this comment.
Will this break older version .net users? Or do we not care about that?
Contributor
Author
There was a problem hiding this comment.
This is not the public interface, the public interface is this which is nullable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch one of many for enabling strict null checks in our code-base.
Relates #3163