chore: enable #nullable iteration 2 #3167
Conversation
| public string? ApiName { get; set; } | ||
|
|
||
| public List<StackFrame> Frames { get; set; } | ||
| public List<StackFrame> Frames { get; set; } = null!; |
There was a problem hiding this comment.
NOTE: !null in this context means the same as using the required keyword. We can't use the required keyword tho since its not available with our TFM we support (netstandard2.0).
There was a problem hiding this comment.
Thats our TFM:
Its supported only in net7+
| using System.Text.Json; | ||
| using Microsoft.Playwright.Transport; | ||
|
|
||
| #nullable enable |
There was a problem hiding this comment.
Already in line 24.
| public string? ApiName { get; set; } | ||
|
|
||
| public List<StackFrame> Frames { get; set; } | ||
| public List<StackFrame> Frames { get; set; } = null!; |
| internal bool _isInternalType; | ||
|
|
||
| internal ChannelOwner(ChannelOwner parent, string guid) : this(parent, null, guid) | ||
| internal ChannelOwner(ChannelOwner parent, string guid) : this(parent, parent._connection, guid) |
There was a problem hiding this comment.
not in this scenario. It can be null when using the other overload. I'll follow-up once I touch more places aka. Connection.cs which will automatically yield this.
| keepNulls); | ||
| var message = new Dictionary<string, object> | ||
| { | ||
| ["id"] = id, |
There was a problem hiding this comment.
Why did this change? Previously it was type-checked, now it's just a dict.
There was a problem hiding this comment.
Remove use-less wrapping type - this is similar to Python now.
| { | ||
| var createObjectInfo = message.Params.Value.ToObject<CreateObjectInfo>(DefaultJsonSerializerOptions); | ||
| CreateRemoteObject(message.Guid, createObjectInfo.Type, createObjectInfo.Guid, createObjectInfo.Initializer); | ||
| CreateRemoteObject(message.Guid, message.Params.Value.GetProperty("type").ToObject<ChannelOwnerType>(), message.Params.GetString("guid", false)!, message.Params?.GetProperty("initializer")); |
There was a problem hiding this comment.
Same, the previous code was arguably more type-safe.
There was a problem hiding this comment.
Internally its similar and more explicit without going through the JsonSerializer infra + we don't need this extra type. I think for use-cases where we don't need to share a type this is preferred (like we do in other places as well).
| public string Name { get; set; } = null!; | ||
|
|
||
| public string MimeType { get; set; } | ||
| public string MimeType { get; set; } = null!; |
There was a problem hiding this comment.
null! is a very indirect way to say that the field is required!
#3163