chore: enable #nullable iteration 3 #3172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables nullable reference types across the Playwright repository to improve code clarity and null-safety.
- Added "#nullable enable" directives to multiple files.
- Updated type declarations and method signatures to use nullable annotations consistently.
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Playwright/Core/APIRequestContext.cs | Enabled nullability and updated field and parameter types. |
| src/Playwright/Core/APIRequest.cs | Enabled nullability and updated option handling for new context. |
| src/Playwright/BrowserType.cs | Added "#nullable enable" directive. |
| src/Playwright/Assertions.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Types/ViewportSize.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Types/RequestAbortErrorCode.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Types/PaperFormat.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Types/DialogType.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Types/BindingSource.cs | Added "#nullable enable" directive and updated constructor usage. |
| src/Playwright/API/TargetClosedException.cs | Updated constructor parameter to allow nullability. |
| src/Playwright/API/Supplements/IResponse.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Supplements/IPlaywright.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Supplements/ILocator.cs | Updated method signatures to use nullable parameters. |
| src/Playwright/API/Supplements/IJSHandle.cs | Updated method signatures to use nullable parameters. |
| src/Playwright/API/Supplements/IFrame.cs | Updated method signatures to use nullable parameters. |
| src/Playwright/API/Supplements/IElementHandle.cs | Updated method signatures to use nullable parameters. |
| src/Playwright/API/Supplements/ICDPSession.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Supplements/IBrowser.cs | Added "#nullable enable" directive. |
| src/Playwright/API/Supplements/IAPIRequestContext.cs | Added "#nullable enable" directive. |
| src/Playwright/API/PlaywrightException.cs | Added "#nullable enable" directive. |
| string dataString = !string.IsNullOrEmpty(options.Data) ? options.Data : options.DataString; | ||
| byte[]? postData = null; | ||
| object? jsonData = null; | ||
| string dataString = (!string.IsNullOrEmpty(options.Data) && options.Data != null) ? options.Data : options.DataString!; |
There was a problem hiding this comment.
The condition '(!string.IsNullOrEmpty(options.Data) && options.Data != null)' is redundant; 'string.IsNullOrEmpty(options.Data)' already checks for null. Consider simplifying the conditional.
Suggested change
| string dataString = (!string.IsNullOrEmpty(options.Data) && options.Data != null) ? options.Data : options.DataString!; | |
| string dataString = !string.IsNullOrEmpty(options.Data) ? options.Data : options.DataString!; |
| storageState = File.ReadAllText(options?.StorageStatePath); | ||
| } | ||
| if (!string.IsNullOrEmpty(storageState)) | ||
| if (!string.IsNullOrEmpty(storageState) && storageState != null) |
There was a problem hiding this comment.
The check '&& storageState != null' is redundant since 'string.IsNullOrEmpty' covers null; consider simplifying the condition.
Suggested change
| if (!string.IsNullOrEmpty(storageState) && storageState != null) | |
| if (!string.IsNullOrEmpty(storageState)) |
yury-s
approved these changes
May 27, 2025
| { | ||
| timeoutAction(); | ||
| return default; | ||
| return default!; |
Member
There was a problem hiding this comment.
Maybe leave a comment that this line is unreachable? Or better yet throw timeoutAction(); or something like that, so that you don't have to add unreachable return statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3163