chore: update readme playwright dependency version#1760
chore: update readme playwright dependency version#1760lubomsky wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Add UpdatePlaywrightVersion.java execution to update playwright dependencies in README.md
@microsoft-github-policy-service agree |
| ); | ||
| private static final Pattern MAVEN_PATTERN = Pattern.compile( | ||
| "(<dependency>\\s*<groupId>com.microsoft.playwright</groupId>\\s*<artifactId>playwright</artifactId>\\s*)<version>\\d+\\.\\d+\\.\\d+</version>(\\s*</dependency>)" | ||
| ); |
There was a problem hiding this comment.
Does it much multiline by default (without MULTILINE flag) ?
| if (!versionMatcher.find()) { | ||
| throw new NoSuchElementException("Project version was not found"); | ||
| } | ||
| String version = versionMatcher.group(1); |
There was a problem hiding this comment.
Version in pom.xml usually refers to the next development version, which hasn't been published yet. Let's set it to major.(minor-1).0 similar to what we did in #1748.
Also would be nice to unify this two places, sot that the versions are patched at the same place with the same deps version.
There was a problem hiding this comment.
maybe we can move it to JS like its done in https://github.com/microsoft/playwright-java/pull/1748/files - then the actual PR should be much smaller.
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
After discussing this offline, we decided to align the readme file with our other language ports and redirect to the main documentation site playwright.dev. We already have infra that keeps the versions in the examples up to date, and it's mote comprehensive than this README. After #1766 there will be no mentions of package versions in the readme.
|
Closing per the comment above. There is no version in the readme any more. |
3 participants
No description provided.