feat(extension): add focusTab option to prevent focus stealing on connect#1471
Open
himself65 wants to merge 1 commit intomicrosoft:mainfrom
Open
feat(extension): add focusTab option to prevent focus stealing on connect#1471himself65 wants to merge 1 commit intomicrosoft:mainfrom
himself65 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…nect When connecting to a tab, the extension previously always activated the tab and focused its window, which steals focus from the terminal. This adds a `focusTab` URL parameter that can be set to `false` to skip focusing. Defaults to `true` for backward compatibility.
Author
|
@microsoft-github-policy-service agree |
Member
|
Can you describe a scenario where this is needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
focusTabURL parameter to the extension connect page that controls whether connecting to a tab activates it and focuses its window.focusTab=falseis passed, the extension skips callingchrome.tabs.update(tabId, { active: true })andchrome.windows.update(windowId, { focused: true }), preventing focus from being stolen from the terminal.truefor backward compatibility.