Skip to content

fix: display error when project is not found#34577

Merged
agg23 merged 4 commits intomicrosoft:mainfrom
agg23:missing-project-id-error
Feb 5, 2025
Merged

fix: display error when project is not found#34577
agg23 merged 4 commits intomicrosoft:mainfrom
agg23:missing-project-id-error

Conversation

@agg23
Copy link
Contributor

@agg23 agg23 commented Jan 31, 2025

Display an error message when a project is not found, such as when its name changes at runtime.

@github-actions

This comment has been minimized.

@agg23 agg23 force-pushed the missing-project-id-error branch from 063f849 to 7016d28 Compare February 4, 2025 18:19
@agg23 agg23 force-pushed the missing-project-id-error branch from 7016d28 to d35371b Compare February 4, 2025 18:19
@agg23 agg23 requested a review from dgozman February 4, 2025 18:20
@agg23 agg23 marked this pull request as ready for review February 4, 2025 18:20
@github-actions

This comment has been minimized.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for this!

@agg23 agg23 requested a review from dgozman February 5, 2025 14:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18

6 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:471:3 › should update har.zip for page with different options @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37789 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 merged commit cb20883 into microsoft:main Feb 5, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants