Skip to content

chore: make localStorage optional when setting storage state#34629

Closed
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Skn0tt:storagestate-localstorage-optional
Closed

chore: make localStorage optional when setting storage state#34629
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Skn0tt:storagestate-localstorage-optional

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Feb 5, 2025

Follow-up to #34591

@Skn0tt Skn0tt requested a review from dgozman February 5, 2025 14:05
@Skn0tt Skn0tt self-assigned this Feb 5, 2025
- `origins` <[Array]<[Object]>>
- `origin` <[string]>
- `localStorage` <[Array]<[Object]>>
- `localStorage` ?<[Array]<[Object]>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised that origins and cookies are not optional either. Maybe I was wrong suggesting this change. Perhaps we should do some archeology, or forget about it.

Copy link
Member Author

@Skn0tt Skn0tt Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's forget about it, we can still do this change in the future.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results for "tests 1"

8 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-1.spec.ts:28:3 › context.cookies() should work @smoke @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/elementhandle-screenshot.spec.ts:231:5 › element screenshot › should wait for element to stop moving @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18

37783 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants