Skip to content

feat(trace): Pin copy address button to the right in the address bar #37802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

feat(trace): Pin copy address button to the right in the address bar #37802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cab312
feat(trace): Pin copy address button to the right in the address bar
cpAdm Oct 11, 2025
fb2763c
fix(trace): Prefer `flex: auto` for address
cpAdm Oct 13, 2025
3c64912
chore(trace): Unnest css selector
cpAdm Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions packages/trace-viewer/src/ui/browserFrame.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,16 @@
font: 400 16px Arial,sans-serif;
margin: 0 16px 0 8px;
padding: 5px 15px;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
display: flex;
align-items: center;
height: 28px;
}

.browser-frame-address-bar > button {
visibility: hidden;
}

.browser-frame-address-bar:hover > button {
visibility: visible;
.browser-frame-address {
flex: auto;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

.browser-frame-menu-bar {
Expand Down
2 changes: 1 addition & 1 deletion packages/trace-viewer/src/ui/browserFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const BrowserFrame: React.FunctionComponent<{
className='browser-frame-address-bar'
title={url || 'about:blank'}
>
{url || 'about:blank'}
<span className='browser-frame-address'>{url || 'about:blank'}</span>
{url && (
<CopyToClipboard value={url} />
)}
Expand Down
13 changes: 5 additions & 8 deletions tests/library/trace-viewer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,20 +473,17 @@ test('should have network request overrides 2', async ({ page, server, runAndTra
await expect.soft(traceViewer.networkRequests).toContainText([/script.jsGET200application\/javascript.*continued/]);
});

test('should show snapshot URL', async ({ page, runAndTrace, server }) => {
test('should show snapshot URL and copy button', async ({ page, runAndTrace, server }) => {
const traceViewer = await runAndTrace(async () => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate('2+2');
});
await traceViewer.snapshotFrame('Evaluate');
const browserFrameAddressBarLocator = traceViewer.page.locator('.browser-frame-address-bar');
await expect(browserFrameAddressBarLocator).toHaveText(server.EMPTY_PAGE);
const copySelectorLocator = browserFrameAddressBarLocator.getByRole('button', { name: 'Copy' });
await expect(copySelectorLocator).toBeHidden();
await browserFrameAddressBarLocator.hover();
await expect(copySelectorLocator).toBeVisible();
const addressBar = traceViewer.page.locator('.browser-frame-address-bar');
await expect(addressBar).toHaveText(server.EMPTY_PAGE);

await traceViewer.page.context().grantPermissions(['clipboard-read', 'clipboard-write']);
await copySelectorLocator.click();
await addressBar.getByRole('button', { name: 'Copy' }).click();
expect(await traceViewer.page.evaluate(() => navigator.clipboard.readText())).toBe(server.EMPTY_PAGE);
});

Expand Down
Loading